linux-kernel - Re: [PATCH AUTOSEL 5.10 23/56] fs: make unlazy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210305124010.GA20055@amd>
Date:   Fri, 5 Mar 2021 13:40:10 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 23/56] fs: make unlazy_walk() error handling
 consistent

On Wed 2021-02-24 07:51:39, Sasha Levin wrote:
> From: Jens Axboe <axboe@...nel.dk>
> 
> [ Upstream commit e36cffed20a324e116f329a94061ae30dd26fb51 ]
> 
> Most callers check for non-zero return, and assume it's -ECHILD (which
> it always will be). One caller uses the actual error return. Clean this
> up and make it fully consistent, by having unlazy_walk() return a bool
> instead. Rename it to try_to_unlazy() and return true on success, and
> failure on error. That's easier to read.
> 
> No functional changes in this patch.
 
Easier to read, but not fixing bug. I don't believe this is suitable
for stable.

Best regards,
								Pavel
								
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)