linux-kernel - Re: [PATCH RESEND][next] hwmon: (max6621) Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210306045439.GA179425@embeddedor>
Date:   Fri, 5 Mar 2021 22:54:39 -0600
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH RESEND][next] hwmon: (max6621) Fix fall-through warnings
 for Clang

Hi Guenter,

On Fri, Mar 05, 2021 at 07:18:47PM -0800, Guenter Roeck wrote:
> On Fri, Mar 05, 2021 at 03:52:58AM -0600, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> > 
> > Link: https://github.com/KSPP/linux/issues/115
> > Acked-by: Guenter Roeck <linux@...ck-us.net>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > ---
> 
> I Acked those, thus assuming that they would be applied through some
> other tree. If that is not the case, you'll need to let me know. The
> resend only means to me that whatever tree was supposed to pick it up
> did not do it, but it doesn't result in any action from my side.

This was not directed at you, in particular. I'm resending this for
the cosideration of whomever is in charge of this code. If this is
not taken or ignored once again, I will consider adding this to
my own tree.

Thanks
--
Gustavo

> >  drivers/hwmon/max6621.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c
> > index 367855d5edae..7821132e17fa 100644
> > --- a/drivers/hwmon/max6621.c
> > +++ b/drivers/hwmon/max6621.c
> > @@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,
> >  		default:
> >  			break;
> >  		}
> > -
> > +		break;
> >  	default:
> >  		break;
> >  	}
> > -- 
> > 2.27.0
> >