linux-kernel - Re: [PATCH] arm64: dts: qcom: Introduce SM8350 HDK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83273ce6-448d-a969-e9bf-97c11d57a38b@somainline.org>
Date:   Sat, 6 Mar 2021 11:34:12 +0100
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Introduce SM8350 HDK

Hi!


> +		vreg_l5b_0p88: ldo5 {
> +			regulator-name = "vreg_l5b_0p88";
> +			regulator-min-microvolt = <880000>;
> +			regulator-max-microvolt = <888000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
> +

This one needs `regulator-allow-set-load` since you specify current settings under UFS nodes, we've seen it not working at all without this property.


> +		vreg_l6b_1p2: ldo6 {
> +			regulator-name = "vreg_l6b_1p2";
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1208000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
> +
> +		vreg_l7b_2p96: ldo7 {
> +			regulator-name = "vreg_l7b_2p96";
> +			regulator-min-microvolt = <2504000>;
> +			regulator-max-microvolt = <2504000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
> +
> +		vreg_l9b_1p2: ldo9 {
> +			regulator-name = "vreg_l9b_1p2";
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};

Ditto for all three


> +&usb_1_dwc3 {
> +	/* TODO: Define USB-C connector properly */

Sidenote: doesn't the new pm8150x (I think?) USB-C driver work on pm8350x?


> +/* PINCTRL - additions to nodes defined in sdm845.dtsi */

sm8350


Aside from these minor comments,

Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>


Konrad