linux-kernel - Re: [PATCH] x86/smpboot: remove duplicate include in smpboot.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 6 Mar 2021 12:18:15 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     menglong8.dong@...il.com
Cc:     tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
        hpa@...or.com, peterz@...radead.org, ggherdovich@...e.cz,
        rafael.j.wysocki@...el.com, rppt@...nel.org,
        nathan.fontenot@....com, ashok.raj@...el.com, brgerst@...il.com,
        linux-kernel@...r.kernel.org,
        Zhang Yunkai <zhang.yunkai@....com.cn>
Subject: Re: [PATCH] x86/smpboot: remove duplicate include in smpboot.c

On Fri, Mar 05, 2021 at 10:56:10PM -0800, menglong8.dong@...il.com wrote:
> From: Zhang Yunkai <zhang.yunkai@....com.cn>
> 
> 'cpu_device_id.h' and 'intel_family.h' included in 'smpboot.c'
> is duplicated. It is also included in the 80th line.
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@....com.cn>

If you send another person's patch, then your SOB needs to follow his/hers:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Also, merge those two x86 patches removing includes into one please.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette