linux-kernel - Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25a6384f-d862-5dda-4fec-8f0555599c75@suse.cz>
Date:   Sat, 6 Mar 2021 20:02:24 +0100
From:   Martin Liška <mliska@...e.cz>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in
 UI

On 3/6/21 3:31 PM, Arnaldo Carvalho de Melo wrote:
> I see, it works only when pressing on source code lines:

Hey.

Yes, I forgot to explicitly mention that.

> 
> Source file location: /usr/src/debug/kernel-5.10.fc33/linux-5.10.19-200.fc33.x86_64/./arch/x86/include/asm/msr.h:205
> 
> So we better improve that message? I.e. 'press on source code lines', or
> 'enable showing source code lines to get line number'?

Fixed that in the attached patch. I got inspiration from 's' hotkey which prints the following warning:
"Only available for assembly lines.".

Thanks,
Martin

View attachment "0001-perf-annotate-show-full-source-location-with-l-hotke.patch" of type "text/x-patch" (6407 bytes)