linux-kernel - Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b43a8735-42fd-be44-01d1-843562b1efd8@kernel.org>
Date:   Sun, 7 Mar 2021 12:44:08 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock
 properties

On 05/03/2021 21:41, Rob Herring wrote:
> On Mon, Feb 15, 2021 at 10:29:15AM +0100, Krzysztof Kozlowski wrote:
>> On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:
>>> Hi Krzysztof,
>>>
>>> On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
>>>> Add common properties appearing in DTSes (assigned-clocks and similar)
>>>> to fix dtbs_check warnings like:
>>>>
>>>>    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
>>>>      adc@...c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
>>>>    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
>>>>      adc@...c0000: assigned-clocks: [[7, 238]] is not of type 'object'
>>>
>>> Does it mean that assigned-clocks related properties have to be added to 
>>> almost all bindings?
>>
>> To my understanding: yes, and we already added it to multiple schemas.
>>
>>> IMHO this is an over-engineering and this has to be 
>>> handled somewhere else...
>>
>> Would have to be made a part of the core schema (just like pinctrl nodes
>> etc).
> 
> That's the case now. It's contingent on having a 'clocks' property in 
> the node.

Do I understand correctly: with new dtschema my patch is not needed anymore?

Best regards,
Krzysztof