linux-kernel - Re: [PATCH v3 1/4] devfreq: Register devfreq as a cooling device on demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <587ae86e-158d-8ffa-319c-66f397f5a218@gmail.com>
Date:   Mon, 8 Mar 2021 00:14:19 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Lukasz Luba <lukasz.luba@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Steven Price <steven.price@....com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v3 1/4] devfreq: Register devfreq as a cooling device on
 demand

On 21. 3. 7. 오후 11:28, Daniel Lezcano wrote:
> On 07/03/2021 15:16, Chanwoo Choi wrote:
>> On 21. 3. 7. 오후 6:45, Daniel Lezcano wrote:
>>> Currently the default behavior is to manually having the devfreq
>>> backend to register themselves as a devfreq cooling device.
>>>
>>> Instead of adding the code in the drivers for the thermal cooling
>>> device registering, let's provide a flag in the devfreq's profile to
>>> tell the common devfreq code to register the newly created devfreq as
>>> a cooling device.
>>>
>>> Suggested-by: Chanwoo Choi <cwchoi00@...il.com>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>>> ---
>>>    V3:
>>>      - Rebased on linux-pm branch without units.h
>>>      - Set the cdev to NULL in case of error
>>>      - Added description for the cdev field in the devfreq structure
>>>    V2:
>>>      - Added is_cooling_device boolean in profile structure
>>>      - Register cooling device when the is_cooling_device boolean is set
>>>      - Remove devfreq cooling device registration in the backend drivers
>>>    V1:
>>>      - Register devfreq as a cooling device unconditionnally
>>> ---
> 
> 
> [ ... ]
> 
>>>        return devfreq;
>>>
>>>    err_init:
>>> @@ -960,6 +971,8 @@ int devfreq_remove_device(struct devfreq *devfreq)
>>>        if (!devfreq)
>>>                return -EINVAL;
>>>
>>> +     thermal_cooling_device_unregister(devfreq->cdev);
>>
>> I have a question. Why don't you use devfreq_cooling_unregister()?
>> When thermal_cooling_device_unregister(), how can we remove
>> the pm_qos_request of devfreq device?
> 
> You are perfectly right. I failed to call the right function :/
> 
> Will fix it with a v4.
> 

Thanks. And, please add 'PM /' prefix for patch in order to
keep the consistent patch title format.

PM / devfreq: Register devfreq as a cooling device on demand

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi