linux-kernel - Re: [PATCH v2] PCI: quirk for preventing bus reset on TI C667X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEQcyBVLIaGWb4sk@rocinante>
Date:   Sun, 7 Mar 2021 01:22:32 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Antti Järvinen <antti.jarvinen@...il.com>
Cc:     helgaas@...nel.org, alex.williamson@...hat.com,
        bhelgaas@...gle.com, kishon@...com, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, m-karicheri2@...com
Subject: Re: [PATCH v2] PCI: quirk for preventing bus reset on TI C667X

Hi Antti,

A few nitpicks, so feel free to ignore these, of course.

If possible, capitalise the subject line.  Also, perhaps "Add quirk to
prevent bus (...)" might read better.

> Some TI keystone C667X devices do no support bus/hot reset. Its PCIESS
[...]

It would be KeyStone in the above sentence.

[...]
> With this change device can be assigned to VMs with VFIO, but it will
> leak state between VMs.

Following-up on Bojrn's question about the state leak, see:
  https://lore.kernel.org/linux-pci/20210129234946.GA124037@bjorn-Precision-5520/

Would there be anything else that has to be done?

Krzysztof