lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Mar 2021 11:18:03 +0200 From: Leon Romanovsky <leon@...nel.org> To: davem@...emloft.net, kuba@...nel.org Cc: Jia-Ju Bai <baijiaju1990@...il.com>, kvalo@...eaurora.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle() On Sun, Mar 07, 2021 at 01:07:57AM -0800, Jia-Ju Bai wrote: > When hif_scatter_req_get() returns NULL to scat_req, no error return > code of ath6kl_htc_rx_bundle() is assigned. > To fix this bug, status is assigned with -EINVAL in this case. > > Reported-by: TOTE Robot <oslab@...nghua.edu.cn> > Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com> > --- > drivers/net/wireless/ath/ath6kl/htc_mbox.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/htc_mbox.c b/drivers/net/wireless/ath/ath6kl/htc_mbox.c > index 998947ef63b6..3f8857d19a0c 100644 > --- a/drivers/net/wireless/ath/ath6kl/htc_mbox.c > +++ b/drivers/net/wireless/ath/ath6kl/htc_mbox.c > @@ -1944,8 +1944,10 @@ static int ath6kl_htc_rx_bundle(struct htc_target *target, > > scat_req = hif_scatter_req_get(target->dev->ar); > > - if (scat_req == NULL) > + if (scat_req == NULL) { > + status = -EINVAL; I'm not sure about it. David. Jakub, Please be warned that patches from this guy are not so great. I looked on 4 patches and 3 of them were wrong (2 in RDMA and 1 for mlx5) plus this patch most likely is incorrect too. Thanks > goto fail_rx_pkt; > + } > > for (i = 0; i < n_scat_pkt; i++) { > int pad_len; > -- > 2.17.1 >
Powered by blists - more mailing lists