linux-kernel - Re: [PATCH v11 02/10] crypto: Add support for ECDSA signature verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d7b4ee1-cf71-ce2d-abaf-2ad1e472f1af@linux.ibm.com>
Date:   Mon, 8 Mar 2021 12:00:05 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au,
        dhowells@...hat.com, zohar@...ux.ibm.com, jarkko@...nel.org
Cc:     linux-kernel@...r.kernel.org, patrick@...terwijk.org,
        linux-integrity@...r.kernel.org
Subject: Re: [PATCH v11 02/10] crypto: Add support for ECDSA signature
 verification

On 3/5/21 3:59 PM, Stefan Berger wrote:
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index a367fcfeb5d4..a31df40591f5 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -247,6 +247,16 @@ config CRYPTO_ECDH
>   	help
>   	  Generic implementation of the ECDH algorithm
>   
> @@ -70,6 +72,30 @@ struct ecc_curve {
>   	u64 *b;
>   };
>   
> +/**
> + * ecc_swap_digits() - Copy ndigits from big endian array to native array
> + * @in:       Input array
> + * @out:      Output array
> + * @ndigits:  Number of digits to copy
> + */
> +static inline void ecc_swap_digits(const u64 *in, u64 *out, unsigned int ndigits)
> +{
> +	const __be64 *src = (__force __be64 *)in;
> +	int i;
> +
> +	for (i = 0; i < ndigits; i++)
> +		out[i] = be64_to_cpu(src[ndigits - 1 - i]);
> +}
> +
> +/**
> + * ecc_get_curve()  - Get a curve given its curve_id
> + *

There's still an additional empty line here (as is the case with other 
existing functions in this file). I will fix this one in v12.