linux-kernel - Re: [PATCH v4 2/8] mm/swapops: Rework swap entry manipulation code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cf3d4c5-b83e-902f-d1c8-a96248ce2ce8@nvidia.com>
Date:   Mon, 8 Mar 2021 10:30:14 -0800
From:   Ralph Campbell <rcampbell@...dia.com>
To:     Alistair Popple <apopple@...dia.com>, <linux-mm@...ck.org>,
        <nouveau@...ts.freedesktop.org>, <bskeggs@...hat.com>,
        <akpm@...ux-foundation.org>
CC:     <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kvm-ppc@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <jhubbard@...dia.com>, <jglisse@...hat.com>,
        Christoph Hellwig <hch@....de>,
        Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH v4 2/8] mm/swapops: Rework swap entry manipulation code


On 3/3/21 10:16 PM, Alistair Popple wrote:
> Both migration and device private pages use special swap entries that
> are manipluated by a range of inline functions. The arguments to these
> are somewhat inconsitent so rework them to remove flag type arguments
> and to make the arguments similar for both read and write entry
> creation.
> 
> Signed-off-by: Alistair Popple <apopple@...dia.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Looks good to me too.
Reviewed-by: Ralph Campbell <rcampbell@...dia.com>