linux-kernel - Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff9fb99f-12ca-c04e-e4bc-1b1c67381cc2@oracle.com>
Date:   Mon, 8 Mar 2021 15:33:33 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org, ross.lagerwall@...rix.com
Cc:     Stefano Stabellini <sstabellini@...nel.org>,
        stable@...r.kernel.org, Julien Grall <julien@....org>,
        Julien Grall <jgrall@...zon.com>
Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an
 eoi is pending


On 3/6/21 11:18 AM, Juergen Gross wrote:
> An event channel should be kept masked when an eoi is pending for it.
> When being migrated to another cpu it might be unmasked, though.
>
> In order to avoid this keep three different flags for each event channel
> to be able to distinguish "normal" masking/unmasking from eoi related
> masking/unmasking and temporary masking. The event channel should only
> be able to generate an interrupt if all flags are cleared.
>
> Cc: stable@...r.kernel.org
> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
> Reported-by: Julien Grall <julien@....org>
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Reviewed-by: Julien Grall <jgrall@...zon.com>
> ---
> V2:
> - introduce a lock around masking/unmasking
> - merge patch 3 into this one (Jan Beulich)
> V4:
> - don't set eoi masking flag in lateeoi_mask_ack_dynirq()


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>


Ross, are you planning to test this?


-boris