linux-kernel - Re: [v8 PATCH 07/13] mm: vmscan: add shrinker_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALvZod4dPe5vMYf+vmL5NTAeVtZvVi06Rx4RCg-6NB2+2unEZg@mail.gmail.com>
Date:   Sun, 7 Mar 2021 22:52:54 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Yang Shi <shy828301@...il.com>
Cc:     Roman Gushchin <guro@...com>, Kirill Tkhai <ktkhai@...tuozzo.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Dave Chinner <david@...morbit.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v8 PATCH 07/13] mm: vmscan: add shrinker_info_protected() helper

On Tue, Feb 16, 2021 at 4:13 PM Yang Shi <shy828301@...il.com> wrote:
>
> The shrinker_info is dereferenced in a couple of places via rcu_dereference_protected
> with different calling conventions, for example, using mem_cgroup_nodeinfo helper
> or dereferencing memcg->nodeinfo[nid]->shrinker_info.  And the later patch
> will add more dereference places.
>
> So extract the dereference into a helper to make the code more readable.  No
> functional change.
>
> Acked-by: Roman Gushchin <guro@...com>
> Acked-by: Kirill Tkhai <ktkhai@...tuozzo.com>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Yang Shi <shy828301@...il.com>

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>