linux-kernel - Re: [PATCH 1/2] arm64: dts: imx8mp: add flexspi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210308083341.6mublqva6lm777gn@pengutronix.de>
Date:   Mon, 8 Mar 2021 09:33:41 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Heiko Schocher <hs@...x.de>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Dong Aisheng <aisheng.dong@....com>,
        devicetree@...r.kernel.org, Peng Fan <peng.fan@....com>,
        Anson Huang <Anson.Huang@....com>,
        Horia Geantă <horia.geanta@....com>,
        Alice Guo <alice.guo@....com>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Joakim Zhang <qiangqing.zhang@....com>,
        Krzysztof Kozlowski <krzk@...nel.org>, Li Jun <jun.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Teresa Remmet <t.remmet@...tec.de>,
        Fabio Estevam <festevam@...il.com>,
        linux-kernel@...r.kernel.org, Jacky Bai <ping.bai@....com>
Subject: Re: [PATCH 1/2] arm64: dts: imx8mp: add flexspi node

Hi Heiko,

On 21-03-08 07:40, Heiko Schocher wrote:
> add node for the flexspi modul on imx8mp.
> 
> Signed-off-by: Heiko Schocher <hs@...x.de>
> 
> ---
> 
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index c7523fd4eae9b..086cfbbef43d7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -36,6 +36,7 @@ aliases {
>  		serial1 = &uart2;
>  		serial2 = &uart3;
>  		serial3 = &uart4;
> +		spi0 = &flexspi;
>  	};
>  
>  	cpus {
> @@ -744,6 +745,21 @@ usdhc3: mmc@...60000 {
>  				status = "disabled";
>  			};
>  
> +			flexspi: spi@...b0000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;

This properties can moved to end just in front of the status property
which should be the last one.

> +				compatible = "nxp,imx8mm-fspi";

Please add a own compatible "nxp,imx8mp-fspi" to the driver which should
be the first patch in your series.

Also the compatible is always the first property.

Regards,
  Marco

> +				reg = <0x30bb0000 0x10000>, <0x8000000 0x10000000>;
> +				reg-names = "fspi_base", "fspi_mmap";
> +				interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX8MP_CLK_QSPI_ROOT>,
> +					 <&clk IMX8MP_CLK_QSPI_ROOT>;
> +				clock-names = "fspi", "fspi_en";
> +				assigned-clock-rates = <80000000>;
> +				assigned-clocks = <&clk IMX8MP_CLK_QSPI>;
> +				status = "disabled";
> +			};
> +
>  			sdma1: dma-controller@...d0000 {
>  				compatible = "fsl,imx8mp-sdma", "fsl,imx8mq-sdma";
>  				reg = <0x30bd0000 0x10000>;
> -- 
> 2.29.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |