linux-kernel - Re: [RFC 1/1] s390/pci: expose a PCI device's UID as its index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Mar 2021 09:42:37 +0100
From:   Viktor Mihajlovski <mihajlov@...ux.ibm.com>
To:     Niklas Schnelle <schnelle@...ux.ibm.com>,
        Krzysztof Wilczyński <kw@...ux.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Narendra K <narendra_k@...l.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stefan Raspl <raspl@...ux.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org
Subject: Re: [RFC 1/1] s390/pci: expose a PCI device's UID as its index



On 3/8/21 8:02 AM, Niklas Schnelle wrote:
> 
> 
> On 3/7/21 9:46 PM, Krzysztof Wilczyński wrote:
>> Hi Niklas,
>>
>> [...]
>>> +static ssize_t index_show(struct device *dev,
>>> +			  struct device_attribute *attr, char *buf)
>>> +{
>>> +	struct zpci_dev *zdev = to_zpci(to_pci_dev(dev));
>>> +	u32 index = ~0;
>>> +
>>> +	if (zpci_unique_uid)
>>> +		index = zdev->uid;
>>> +
>>> +	return sprintf(buf, "%u\n", index);
>> [...]
>>
>> Would it be possible to use the new sysfs_emit() rather than sprintf()
>> even though the zpci_attr macro and still use mio_enabled_show() still
>> would use sprintf().  What do you think?
>>
>> See https://www.kernel.org/doc/html/latest/filesystems/sysfs.html for
>> the changes in the internal API.
>>
>> Krzysztof
>>
> 
> Of course that makes sense and thanks for pointing me to this API!
> @Viktor, may I carry your R-b over?
> 
Sure, please go ahead.
> I'll also update the other attributes in a clean up patch.
> 
> Thanks,
> Niklas
> 

-- 
Kind Regards,
    Viktor