linux-kernel - Re: [PATCH] usb: typec: tcpm: turn tcpm_ams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a15af59-2c28-e278-0127-ba76dd3cc2e6@gmail.com>
Date:   Mon, 8 Mar 2021 11:59:43 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, linux@...ck-us.net
Cc:     heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function

Hello!

On 08.03.2021 9:21, Yang Li wrote:

> This function always return '0' and no callers use the return value.

    Returns.

> So make it a void function.
> 
> This eliminates the following coccicheck warning:
> ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
> Return "0" on line 794
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/usb/typec/tcpm/tcpm.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index be0b646..6ee984e 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
>   	return TYPEC_CC_RP_DEF;
>   }
>   
> -static int tcpm_ams_finish(struct tcpm_port *port)
> +static void tcpm_ams_finish(struct tcpm_port *port)
>   {
> -	int ret = 0;
> -
>   	tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);
>   
>   	if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
> @@ -791,7 +789,7 @@ static int tcpm_ams_finish(struct tcpm_port *port)
>   	port->in_ams = false;
>   	port->ams = NONE_AMS;
>   
> -	return ret;
> +	return;

    Just remove that *return*.

>   }
[...]

MBR, Sergei