linux-kernel - Re: [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d01ccf05-abbf-7f65-396d-31735d9b31f1@gmail.com>
Date:   Mon, 8 Mar 2021 17:26:18 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>, airlied@...ux.ie,
        daniel@...ll.ch, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, lkml@....ORG,
        matthew.auld@...el.com, rodrigo.vivi@...el.com
Cc:     intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: drm: i915: fix error return code of
 igt_buddy_alloc_smoke()



On 2021/3/8 17:18, Chris Wilson wrote:
> Quoting Jia-Ju Bai (2021-03-08 08:59:52)
>> When i915_random_order() returns NULL to order, no error return code of
>> igt_buddy_alloc_smoke() is assigned.
>> To fix this bug, err is assigned with -EINVAL in this case.
> It would not be EINVAL since that is used for a reference failure, but
> in this case the idea was to return 0 as no testing was done and the
> ENOMEM was raised before testing began i.e. not an internal and
> unexpected driver allocation failure.
> -Chris

Okay, thanks for your reply :)


Best wishes,
Jia-Ju Bai