linux-kernel - Re: [PATCH] HID: plantronics: Workaround for double volume key presses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2103081108590.12405@cbobk.fhfr.pm>
Date:   Mon, 8 Mar 2021 11:09:45 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Maxim Mikityanskiy <maxtram95@...il.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Terry Junge <terry.junge@...ntronics.com>,
        JD Cole <jd.cole@...ntronics.com>, JD Cole <jd@....me>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: plantronics: Workaround for double volume key
 presses

On Sun, 7 Feb 2021, Maxim Mikityanskiy wrote:

> Plantronics Blackwire 3220 Series (047f:c056) sends HID reports twice
> for each volume key press. This patch adds a quirk to hid-plantronics
> for this product ID, which will ignore the second volume key press if
> it happens within 5 ms from the last one that was handled.
> 
> The patch was tested on the mentioned model only, it shouldn't affect
> other models, however, this quirk might be needed for them too.
> Auto-repeat (when a key is held pressed) is not affected, because the
> rate is about 3 times per second, which is far less frequent than once
> in 5 ms.
> 
> Fixes: 81bb773faed7 ("HID: plantronics: Update to map volume up/down controls")
> Signed-off-by: Maxim Mikityanskiy <maxtram95@...il.com>
> ---
> People from Plantronics, maybe you could advise on a better fix than
> filtering duplicate events on driver level? Do you happen to know why
> they occur in the first place? Are any other headsets affected?

Makes one wonder how the Windows driver is dealing with this indeed.
Anyway, as there doesn't seem to be better cure available for now, I have 
applied the patch. Thanks,

-- 
Jiri Kosina
SUSE Labs