linux-kernel - Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12fe8fa5-1014-634a-940d-d33d5b7bbd6e@windriver.com>
Date:   Mon, 8 Mar 2021 18:15:47 +0800
From:   "quanyang.wang" <quanyang.wang@...driver.com>
To:     Michal Simek <michal.simek@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328

Hi Michal,

On 3/8/21 4:47 PM, Michal Simek wrote:
> Hi,
>
> On 3/8/21 9:35 AM, Laurent Pinchart wrote:
>> Hi Quanyang,
>>
>> Thank you for the patch.
>>
>> On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@...driver.com wrote:
>>> From: Quanyang Wang <quanyang.wang@...driver.com>
>>>
>>> The function of_i2c_get_board_info will call of_modalias_node to check
>>> if a device_node contains "compatible" string. So let's assign the
>>> proper string "silabs,si5328" to clock-generator@...s compatible
>>> property to eliminate the error info as below:
>> As far as I can tell, "silabs,si5328" isn't documented in
>> Documentation/devicetree/bindings/. We need DT bindings before making
>> use of the compatible string.
>>
> the second option is to remove/comment this node.

Thank you for your suggestion.

  I will send a new patch to delete these nodes and add some comments there.

Best Regards

Quanyang

>
> Thanks,
> Michal