linux-kernel - [PATCH 2/2] usb: webcam: Invalid size of Processing Unit Descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210308102735.9251-2-pawell@gli-login.cadence.com>
Date:   Mon, 8 Mar 2021 11:27:35 +0100
From:   Pawel Laszczak <pawell@...ence.com>
To:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>
CC:     <linux-api@...r.kernel.org>, <laurent.pinchart@...asonboard.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <peter.chen@...nel.org>, <kurahul@...ence.com>,
        Pawel Laszczak <pawell@...ence.com>
Subject: [PATCH 2/2] usb: webcam: Invalid size of Processing Unit Descriptor

From: Pawel Laszczak <pawell@...ence.com>

According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.

Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds bmVideoStandards into
uvc_processing_unit_descriptor structure.

Signed-off-by: Pawel Laszczak <pawell@...ence.com>
---
 include/uapi/linux/usb/video.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h
index d854cb19c42c..2a54e8fdd341 100644
--- a/include/uapi/linux/usb/video.h
+++ b/include/uapi/linux/usb/video.h
@@ -302,6 +302,7 @@ struct uvc_processing_unit_descriptor {
 	__u8   bControlSize;
 	__u8   bmControls[2];
 	__u8   iProcessing;
+	__u8   bmVideoStandards;
 } __attribute__((__packed__));
 
 #define UVC_DT_PROCESSING_UNIT_SIZE(n)			(9+(n))
-- 
2.25.1