linux-kernel - Re: [PATCH v2] tracing/tools: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0c93539788a342f68d7cb16bab3290f66e61915.camel@bmw.de>
Date:   Mon, 8 Mar 2021 11:40:01 +0000
From:   <Viktor.Rosendahl@....de>
To:     <vulab@...as.ac.cn>, <rostedt@...dmis.org>,
        <colin.king@...onical.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tracing/tools: Remove unneeded semicolon

On Mon, 2021-03-08 at 02:24 +0000, Xu Wang wrote:
> fix semicolon.cocci warning:
> tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Reviewed-by: Viktor Rosendahl <Viktor.Rosendahl@....de>

> ---
> Changes since v2:
> - Fix another instance of superfluous semicolon.
> ---
>  tools/tracing/latency/latency-collector.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/tracing/latency/latency-collector.c
> b/tools/tracing/latency/latency-collector.c
> index b69de9263ee6..3a2e6bb781a8 100644
> --- a/tools/tracing/latency/latency-collector.c
> +++ b/tools/tracing/latency/latency-collector.c
> @@ -1018,7 +1018,7 @@ static long go_to_sleep(const struct entry *req)
>  		cond_timedwait(&printstate.cond, &printstate.mutex, &future);
>  		if (time_has_passed(&future))
>  			break;
> -	};
> +	}
>  
>  	if (printstate_has_new_req_arrived(req))
>  		delay = -1;
> @@ -1941,7 +1941,7 @@ static void scan_arguments(int argc, char *argv[])
>  			if (value < 0) {
>  				warnx("TIME must be >= 0\n");
>  				show_usage();
> -				;
> +				exit(0);
>  			}
>  			trace_enable = true;
>  			use_random_sleep = true;

best regards,

Viktor