linux-kernel - Re: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h7llhnfe.fsf@suse.de>
Date:   Mon, 08 Mar 2021 11:53:09 +0000
From:   Richard Palethorpe <rpalethorpe@...e.de>
To:     kernel test robot <oliver.sang@...el.com>
Cc:     "huangjianan@...o.com" <huangjianan@...o.com>, lkp@...el.com,
        Linux Memory Management List <linux-mm@...ck.org>,
        Chao Yu <yuchao0@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Guo Weichao <guoweichao@...o.com>, ltp@...ts.linux.it
Subject: Re: [LTP] [f2fs]  02eb84b96b: ltp.swapon03.fail

Hello,

> kern  :err   : [  187.461914] F2FS-fs (sda1): Swapfile does not align to section

> commit 02eb84b96bc1b382dd138bf60724edbefe77b025
> Author: huangjianan@...o.com <huangjianan@...o.com>
> Date:   Mon Mar 1 12:58:44 2021 +0800

>     f2fs: check if swapfile is section-alligned

>     If the swapfile isn't created by pin and fallocate, it can't be
>     guaranteed section-aligned, so it may be selected by f2fs gc. When
>     gc_pin_file_threshold is reached, the address of swapfile may change,
>     but won't be synchronized to swap_extent, so swap will write to wrong
>     address, which will cause data corruption.

>     Signed-off-by: Huang Jianan <huangjianan@...o.com>
>     Signed-off-by: Guo Weichao <guoweichao@...o.com>
>     Reviewed-by: Chao Yu <yuchao0@...wei.com>
>     Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

The test uses fallocate to preallocate the swap file and writes zeros to
it. I'm not sure what pin refers to?

-- 
Thank you,
Richard.