linux-kernel - Re: [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device on demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c33ea5f5-1f0e-d081-5f8d-9319536ca215@arm.com>
Date:   Mon, 8 Mar 2021 12:04:14 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     cwchoi00@...il.com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, steven.price@....com,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device
 on demand



On 3/8/21 12:00 PM, Daniel Lezcano wrote:
> On 08/03/2021 10:53, Lukasz Luba wrote:
>> Hi Daniel,
>>
>> In general the approach is good. If there is a special GPU driver, which
>> would like to provide 'struct devfreq_cooling_power *' it would leave
>> 'is_cooling_device=false' and register manually:
>> devfreq_cooling_em_register(df, dfc_power);
>>
>> Please find only a few minor comments below.
>>
>>
>> On 3/8/21 9:16 AM, Daniel Lezcano wrote:
>>> Currently the default behavior is to manually having the devfreq
>>> backend to register themselves as a devfreq cooling device.
>>>
>>> Instead of adding the code in the drivers for the thermal cooling
>>> device registering, let's provide a flag in the devfreq's profile to
>>> tell the common devfreq code to register the newly created devfreq as
>>> a cooling device.
>>>
>>> Suggested-by: Chanwoo Choi <cwchoi00@...il.com>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>>> ---
> 
> [ ... ]
> 
>>> +    struct thermal_cooling_device *cdev;
>>
>> The linux/thermal.h for 'cdev' would be needed in this header.
> 
> May be just a forward declaration ?
> 
> struct thermal_cooling_device;

Make sense

Regards,
Lukasz