linux-kernel - Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Mar 2021 03:19:43 +0000
From:   "nakamura.shun@...itsu.com" <nakamura.shun@...itsu.com>
To:     Jiri Olsa <jolsa@...hat.com>
CC:     John Garry <john.garry@...wei.com>,
        "will@...nel.org" <will@...nel.org>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "leo.yan@...aro.org" <leo.yan@...aro.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name

Hi, jirka

> > > > From: Shunsuke Nakamura <nakamura.shun@...fujitsu.com>
> > > > 
> > > > Add the lexical definition of event name so that the numbers are recognizable.
> > > > 
> > > 
> > > Sorry for the hassle, but it's not clear that we got a definitive 
> > > conclusion on this patch from v6 series:
> > > 
> > > https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/
> > > 
> > > Would it be so much worse for you to change format of these event names 
> > > to not start with a numberic?
> > I was trying to match the specifications published by Fujitsu exactly.
> > We also thought that being able to parse event names starting with a number would be an improvement for perf.
> > We've discussed it with the team, but we decided to change the event name.
> 
> hum, I'm not sure what's the final decision in here.. are you keeping
> numbers in the start? would be much easier if you did not ;-)
I don't keep the event name starting with a number.

v8 patch serase changed the event name starting with a number to start with "_".
https://lore.kernel.org/linux-arm-kernel/20210305101841.3133721-1-nakamura.shun@fujitsu.com/

Best Regards
Shunsuke