linux-kernel - Re: [PATCH v8 6/6] mfd: bd9576: Add safety limit/monitoring registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 08 Mar 2021 17:09:45 +0200
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-power@...rohmeurope.com, linux-watchdog@...r.kernel.org,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Subject: Re: [PATCH v8 6/6] mfd: bd9576: Add safety limit/monitoring
 registers


On Mon, 2021-03-08 at 13:47 +0000, Lee Jones wrote:
> On Thu, 11 Feb 2021, Matti Vaittinen wrote:
> 
> > ROHM BD9576 contains safety features like over/under voltage
> > detection,
> > over curren detection and over temperature detection. Add the
> > configuration register information.
> > 
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > ---
> > 
> > Changes since v7:
> > 	New patch
> > 
> >  include/linux/mfd/rohm-bd957x.h | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/include/linux/mfd/rohm-bd957x.h
> > b/include/linux/mfd/rohm-bd957x.h
> > index 3f351a1ae4ab..2bd35260ee8e 100644
> > --- a/include/linux/mfd/rohm-bd957x.h
> > +++ b/include/linux/mfd/rohm-bd957x.h
> > @@ -116,6 +116,25 @@ enum {
> >  #define BD957X_REG_VOUT4_TUNE		0x59
> >  #define BD957X_REG_VOUTL1_TUNE		0x5c
> >  
> > +#define BD9576_REG_VOUT1_OVD		0x51
> > +#define BD9576_REG_VOUT1_UVD		0x52
> > +#define BD9576_REG_VOUT2_OVD		0x54
> > +#define BD9576_REG_VOUT2_UVD		0x55
> > +#define BD9576_REG_VOUT3_OVD		0x57
> > +#define BD9576_REG_VOUT3_UVD		0x58
> > +#define BD9576_REG_VOUT4_OVD		0x5a
> > +#define BD9576_REG_VOUT4_UVD		0x5b
> > +#define BD9576_REG_VOUTL1_OVD		0x5d
> > +#define BD9576_REG_VOUTL1_UVD		0x5e
> > +
> > +#define BD9576_MASK_XVD			0x7f
> > +
> > +#define BD9576_REG_VOUT1S_OCW		0x5f
> > +#define BD9576_REG_VOUT1S_OCP		0x60
> > +
> > +#define BD9576_MASK_VOUT1S_OCW		0x3f
> > +#define BD9576_MASK_VOUT1S_OCP		0x3f
> 
> Just a quick check, are these meant to be the same value?

Thanks for the check. They are both same value.

> 
> If so:
> 
> For my own reference (apply this as-is to your sign-off block):
> 
>   Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> 
Thanks, I'll add your ack.

Best Regards
	Matti