linux-kernel - Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12c5050f-feb3-e07f-45d2-5e89b678841a@kernel.org>
Date:   Mon, 8 Mar 2021 16:33:44 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Timon Baetz <timon.baetz@...tonmail.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency
 unconditional

On 08/03/2021 16:29, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Some of the extcon interfaces have a fallback implementation that can
> be used when EXTCON is disabled, but some others do not, causing a
> build failure:
> 
> drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of function 'devm_extcon_register_notifier_all' [-Werror,-Wimplicit-function-declaration]
>                 ret = devm_extcon_register_notifier_all(&pdev->dev, charger->edev,
>                       ^
> drivers/power/supply/max8997_charger.c:261:9: note: did you mean 'devm_extcon_register_notifier'?
> include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier' declared here
> static inline int devm_extcon_register_notifier(struct device *dev,
> 
> I assume there is no reason to actually build this driver without extcon
> support, so a hard dependency is the easiest fix. Alternatively the
> header file could be extended to provide additional inline stubs.

Hi Arnd,

Thanks for the patch but I think I got it covered with:
https://lore.kernel.org/lkml/20210215100610.19911-2-cw00.choi@samsung.com/
(sent via extcon tree).

Did you experience a new/different issue?

Best regards,
Krzysztof