linux-kernel - Re: [PATCH] Revert "pinctrl: intel: Split intel_pinctrl_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Mar 2021 17:35:59 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Maximilian Luz <luzmaximilian@...il.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Daniel Scally <djrscally@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "pinctrl: intel: Split
 intel_pinctrl_add_padgroups() for better maintenance"

On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> Following commit 036e126c72eb ("pinctrl: intel: Split
> intel_pinctrl_add_padgroups() for better maintenance"),
> gpiochip_get_desc() is broken on some Kaby Lake R devices (specifically
> a Microsoft Surface Book 2), returning -EINVAL for GPIOs that in reality
> should be there (they are defined in ACPI and have been accessible
> previously). Due to this, gpiod_get() fails with -ENOENT.
> 
> Reverting this commit fixes that issue and the GPIOs in question are
> accessible again.

I would like to have more information.
Can you enable PINCTRL and GPIO debug options in the kernel, and show dmesg
output (when kernel command line has 'ignore_loglevel' option) for both working
and non-working cases?

Also if it's possible to have DSDT.dsl of the device in question along with
output of `grep -H 15 /sys/bus/acpi/devices/*/status`.

> There is probably a better option than straight up reverting this, so
> consider this more of a bug-report.

Indeed.

-- 
With Best Regards,
Andy Shevchenko