linux-kernel - Re: [3/3,v3] tools/power turbostat: Enable accumulate RAPL display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210308161548.GA37664@chenyu-desktop>
Date:   Tue, 9 Mar 2021 00:15:48 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     Doug Smythies <dsmythies@...us.net>,
        youling257 <youling257@...il.com>
Cc:     youling257 <youling257@...il.com>, lenb@...nel.org,
        rjw@...ysocki.net, linux-kernel@...r.kernel.org,
        Len Brown <len.brown@...el.com>, Chen Yu <yu.c.chen@...el.com>
Subject: Re: [3/3,v3] tools/power turbostat: Enable accumulate RAPL display

Hi,
On Mon, Mar 08, 2021 at 07:37:07AM -0800, Doug Smythies wrote:
> On Mon, Mar 8, 2021 at 5:50 AM youling257 <youling257@...il.com> wrote:
> >
> > this cause turbostat not work on amd cpu.
> >
> > root@...alhost:~# /turbostat
> > turbostat version 20.09.30 - Len Brown <lenb@...nel.org>
> > CPUID(0): AuthenticAMD 0xd CPUID levels; 0x8000001f xlevels; family:model:stepping 0x17:18:1 (23:24:1)
> 
> There are already two fixes for this in the queue.
> https://marc.info/?l=linux-pm&m=161382097503925&w=2
> https://marc.info/?l=linux-pm&m=161141701219263&w=2
Thanks for reporting and pointing this out. I assume these two patches are both fixing the
same issue? It looks like these two patches should be merged into one:
1. Bingsong's patch access MSR_PKG_ENERGY_STAT only when RAPL_AMD_F17H is set,
   which is consistent with the original context.
2. Bas Nieuwenhuizen's patch also fixes the issue in idx_valid()
   in case RAPL_PKG was not set but with RAPL_AMD_F17H set.

thanks,
Chenyu