linux-kernel - Re: [PATCH] arm64: dts: zynqmp: Remove si5328 device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66e639c2-a1da-8ca5-2031-fe37eb14d740@xilinx.com>
Date:   Mon, 8 Mar 2021 17:27:54 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     <quanyang.wang@...driver.com>, Rob Herring <robh+dt@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     Krzysztof Kozlowski <krzk@...nel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Remove si5328 device nodes



On 3/8/21 12:54 PM, quanyang.wang@...driver.com wrote:
> From: Quanyang Wang <quanyang.wang@...driver.com>
> 
> The function of_i2c_get_board_info will call of_modalias_node to check
> if a device_node contains "compatible" string. But for the device si5328
> at zcu102/zcu106 boards, there is no proper DT bindings for them. So remove
> si5328 device nodes from dts files to eliminate the error info in the boot
> message:
> 
> i2c i2c-10: of_i2c: modalias failure on /axi/i2c@...30000/i2c-mux@...i2c@...lock-generator@69
> i2c i2c-10: Failed to create I2C device for /axi/i2c@...30000/i2c-mux@...i2c@...lock-generator@69
> 
> Signed-off-by: Quanyang Wang <quanyang.wang@...driver.com>
> ---
>  .../boot/dts/xilinx/zynqmp-zcu102-revA.dts    | 20 +------------------
>  .../boot/dts/xilinx/zynqmp-zcu106-revA.dts    | 20 +------------------
>  2 files changed, 2 insertions(+), 38 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 12e8bd48dc8c..eca6c2de84a7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -580,25 +580,7 @@ i2c@4 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <4>;
> -			si5328: clock-generator@69 {/* SI5328 - u20 */
> -				reg = <0x69>;
> -				/*
> -				 * Chip has interrupt present connected to PL
> -				 * interrupt-parent = <&>;
> -				 * interrupts = <>;
> -				 */
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				#clock-cells = <1>;
> -				clocks = <&refhdmi>;
> -				clock-names = "xtal";
> -				clock-output-names = "si5328";
> -
> -				si5328_clk: clk0@0 {
> -					reg = <0>;
> -					clock-frequency = <27000000>;
> -				};
> -			};
> +			/* SI5328 - u20 */
>  		};
>  		/* 5 - 7 unconnected */
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 18771e868399..eff7c6447087 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -581,25 +581,7 @@ i2c@4 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <4>;
> -			si5328: clock-generator@69 {/* SI5328 - u20 */
> -				reg = <0x69>;
> -				/*
> -				 * Chip has interrupt present connected to PL
> -				 * interrupt-parent = <&>;
> -				 * interrupts = <>;
> -				 */
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				#clock-cells = <1>;
> -				clocks = <&refhdmi>;
> -				clock-names = "xtal";
> -				clock-output-names = "si5328";
> -
> -				si5328_clk: clk0@0 {
> -					reg = <0>;
> -					clock-frequency = <27000000>;
> -				};
> -			};
> +			/* SI5328 - u20 */
>  		};
>  		i2c@5 {
>  			#address-cells = <1>;
> 

Applied.
M