linux-kernel - Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fc305c55e06c5740375013bc9a4d305ad985ed1.camel@fi.rohmeurope.com>
Date:   Mon, 8 Mar 2021 16:31:12 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "arnd@...nel.org" <arnd@...nel.org>
CC:     "timon.baetz@...tonmail.com" <timon.baetz@...tonmail.com>,
        "sre@...nel.org" <sre@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency
 unconditional

On Mon, 2021-03-08 at 18:06 +0200, Andy Shevchenko wrote:
> On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann <arnd@...nel.org> wrote:
> 
> > -       depends on EXTCON || !EXTCON
> 
> I stumbled over this.
> What is the point of having this line at all?
> What magic trick does it serve for?

The logic was somewhat hairy. I used it once for BD70528 watchdog which
provides lock functions for RTC - or stubs if WDG is not used. Problem
which that solved was that when RTC was built-in and WDG was a module -
these functions were missing. It might've been Guenter or A. Belloni
who suggested it.

I don't remember 100% sure but I think it might require EXTCON to be
build as a module. I guess the discussion I had regarding BD70528 can
be found from lore.kernel.org - but it is probably buried deep... Maybe
someone will give better and more definite answer.

Best Regards
	Matti Vaittinen