linux-kernel - Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83240e9d-383a-74a9-3222-68cf42d3d0e1@gmail.com>
Date:   Wed, 10 Mar 2021 00:53:35 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Dong Aisheng <aisheng.dong@....com>, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     dongas86@...il.com, kernel@...gutronix.de, shawnguo@...nel.org,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
        cw00.choi@...sung.com, abel.vesa@....com
Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq
 as resume_freq

On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
> Use the more accurate returned new_freq as resume_freq.
> It's the same as how devfreq->previous_freq was updated.
> 
> Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> ---
>   drivers/devfreq/devfreq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 6e80bf70e7b3..ce569bd9adfa 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
>   	devfreq->previous_freq = new_freq;
>   
>   	if (devfreq->suspend_freq)
> -		devfreq->resume_freq = cur_freq;
> +		devfreq->resume_freq = new_freq;
>   
>   	return err;
>   }
> 

This patch fixes the previous patch[1]. So that you need to
add 'Fixes' tag as following:

Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a 
devfreq device")

commit 83f8ca45afbf041e312909f442128b99657d90b7
Refs: v4.20-rc6-2-g83f8ca45afbf
Author:     Lukasz Luba <lukasz.luba@....com>
AuthorDate: Wed Dec 5 12:05:53 2018 +0100
Commit:     MyungJoo Ham <myungjoo.ham@...sung.com>
CommitDate: Tue Dec 11 11:09:47 2018 +0900

     PM / devfreq: add support for suspend/resume of a devfreq device


-- 
Best Regards,
Samsung Electronics
Chanwoo Choi