linux-kernel - Re: [PATCH net v3 2/2] net: avoid infinite loop in mpls_gso_segment when mpls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c2f075e-ea66-66df-82e4-2c5fa71b2d43@gmail.com>
Date:   Tue, 9 Mar 2021 08:55:42 -0700
From:   David Ahern <dsahern@...il.com>
To:     Balazs Nemeth <bnemeth@...hat.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, mst@...hat.com, jasowang@...hat.com,
        davem@...emloft.net, willemb@...gle.com,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH net v3 2/2] net: avoid infinite loop in mpls_gso_segment
 when mpls_hlen == 0

On 3/9/21 4:31 AM, Balazs Nemeth wrote:
> A packet with skb_inner_network_header(skb) == skb_network_header(skb)
> and ETH_P_MPLS_UC will prevent mpls_gso_segment from pulling any headers
> from the packet. Subsequently, the call to skb_mac_gso_segment will
> again call mpls_gso_segment with the same packet leading to an infinite
> loop. In addition, ensure that the header length is a multiple of four,
> which should hold irrespective of the number of stacked labels.
> 
> Signed-off-by: Balazs Nemeth <bnemeth@...hat.com>
> ---
>  net/mpls/mpls_gso.c | 3 +++
>  1 file changed, 3 insertions(+)
> 


Reviewed-by: David Ahern <dsahern@...nel.org>