linux-kernel - Re: patch: do_wait: make PIDTYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <383ff3ab-ef13-1c6e-7794-ecfffc6044d4@torproject.org>
Date:   Tue, 9 Mar 2021 10:18:18 -0600
From:   Jim Newsome <jnewsome@...project.org>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Christian Brauner <christian@...uner.io>,
        linux-kernel@...r.kernel.org
Subject: Re: patch: do_wait: make PIDTYPE_PID case O(1) instead of O(n)

Thanks for the quick review!

On 3/9/21 02:56, Oleg Nesterov wrote:
> I'd suggest to put this PIDTYPE_PID code into the new function.

Done

> No, you don't need rcu lock, tasklist_lock is sufficient

Done

> This is wrong, you forgot to drop tasklist_lock.

Done

>> +		real_parent = !target->real_parent ? target->parent :
>> +						     target->real_parent;
> 
> Hmm, I don't understand the line above... perhaps it connects to the
> question below.

I'd mistakenly thought `real_parent` was NULL if the target wasn't being
traced (or was being traced by the real parent). It looks like indeed
this should always be set, though.

> Afaics, parent/real_parent can't be NULL if pid_task() succeeds.

Done

> Please redo and send V2 ;)

Sent with subject "[PATCH v2] do_wait: make PIDTYPE_PID case O(1)
instead of O(n)"