linux-kernel - Re: [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLk5LWKarMxfnXhJ5VJZMvWEYnCnhP2qQ+LgOfUZALiyA@mail.gmail.com>
Date:   Tue, 9 Mar 2021 12:21:50 -0700
From:   Rob Herring <robh@...nel.org>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     Jonas Gorski <jonas.gorski@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Maxime Ripard <maxime@...no.tech>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions

On Sun, Mar 7, 2021 at 3:08 AM Álvaro Fernández Rojas <noltari@...il.com> wrote:
>
> Hi Rob,
>
> El 06/03/2021 a las 22:17, Rob Herring escribió:
> > On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote:
> >> Add missing timer reset definitions for BCM63268.
> >>
> >> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> >> ---
> >>   include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
> >> index 6a6403a4c2d5..d87a7882782a 100644
> >> --- a/include/dt-bindings/reset/bcm63268-reset.h
> >> +++ b/include/dt-bindings/reset/bcm63268-reset.h
> >> @@ -23,4 +23,8 @@
> >>   #define BCM63268_RST_PCIE_HARD     17
> >>   #define BCM63268_RST_GPHY  18
> >>
> >> +#define BCM63268_TRST_SW    29
> >> +#define BCM63268_TRST_HW    30
> >> +#define BCM63268_TRST_POR   31
> >
> > Numbering should be local to the provider, so shouldn't this be 0-2?
> > Unless these numbers correspond to something in the h/w (bit positions
> > for example).
>
> Numbering corresponds to bit positions in the HW:

Okay, good.

Acked-by: Rob Herring <robh@...nel.org>