linux-kernel - Re: [PATCH 05/10] mm/migrate: demote pages during reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71db9a12-f81e-a341-b3ab-bf66d3c1ab39@intel.com>
Date:   Tue, 9 Mar 2021 15:05:57 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Yang Shi <shy828301@...il.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Yang Shi <yang.shi@...ux.alibaba.com>,
        David Rientjes <rientjes@...gle.com>,
        Huang Ying <ying.huang@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH 05/10] mm/migrate: demote pages during reclaim

On 3/8/21 4:10 PM, Yang Shi wrote:
>> +static struct page *alloc_demote_page(struct page *page, unsigned long node)
>> +{
>> +       struct migration_target_control mtc = {
>> +               /*
>> +                * Fail the allocation quickly and quietly.  When this
>> +                * happens, 'page; will likely just be discarded instead
>> +                * of migrated.
>> +                */
>> +               .gfp_mask = GFP_HIGHUSER_MOVABLE | __GFP_NORETRY | __GFP_NOWARN,
>> +               .nid = node
> I recall I pointed out __GFP_THISNODE should be needed to guarantee
> the allocation doesn't fallback. But it seems it is not solved yet or
> it is guaranteed by the other way?

Sorry about missing that before.  This mask definitely needs
__GFP_THISNODE.  I've added it for the next version.