linux-kernel - Re: [PATCH net] net: dsa: xrs700x: check if partner is same as port in hsr join

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210309001052.jxta3e7eilkgo64u@skbuf>
Date:   Tue, 9 Mar 2021 02:10:52 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     George McCollister <george.mccollister@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: xrs700x: check if partner is same as port
 in hsr join

On Mon, Mar 08, 2021 at 05:38:22PM -0600, George McCollister wrote:
> Don't assign dp to partner if it's the same port that xrs700x_hsr_join
> was called with. The partner port is supposed to be the other port in
> the HSR/PRP redundant pair not the same port. This fixes an issue
> observed in testing where forwarding between redundant HSR ports on this
> switch didn't work depending on the order the ports were added to the
> hsr device.
> 
> Fixes: bd62e6f5e6a9 ("net: dsa: xrs700x: add HSR offloading support")
> Signed-off-by: George McCollister <george.mccollister@...il.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>