linux-kernel - Re: [PATCH v2] bus: mhi: Add Qcom WWAN control driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEcvksXq1Rt0wCxb@kroah.com>
Date:   Tue, 9 Mar 2021 09:19:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     manivannan.sadhasivam@...aro.org, hemantk@...eaurora.org,
        linux-arm-msm@...r.kernel.org, aleksander@...ksander.es,
        linux-kernel@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        netdev@...r.kernel.org, bjorn.andersson@...aro.org
Subject: Re: [PATCH v2] bus: mhi: Add Qcom WWAN control driver

On Mon, Mar 08, 2021 at 09:59:27PM +0100, Loic Poulain wrote:
> The MHI WWWAN control driver allows MHI Qcom based modems to expose
> different modem control protocols to userspace, so that userspace
> modem tools or daemon (e.g. ModemManager) can control WWAN config
> and state (APN config, SMS, provider selection...). A Qcom based
> modem can expose one or several of the following protocols:
> - AT: Well known AT commands interactive protocol (microcom, minicom...)
> - MBIM: Mobile Broadband Interface Model (libmbim, mbimcli)
> - QMI: Qcom MSM/Modem Interface (libqmi, qmicli)
> - QCDM: Qcom Modem diagnostic interface (libqcdm)
> - FIREHOSE: XML-based protocol for Modem firmware management
> 	    (qmi-firmware-update)
> 
> The different interfaces are exposed as character devices, in the same
> way as for USB modem variants.
> 
> Note that this patch is mostly a rework of the earlier MHI UCI
> tentative that was a generic interface for accessing MHI bus from
> userspace. As suggested, this new version is WWAN specific and is
> dedicated to only expose channels used for controlling a modem, and
> for which related opensource user support exist. Other MHI channels
> not fitting the requirements will request either to be plugged to
> the right Linux subsystem (when available) or to be discussed as a
> new MHI driver (e.g AI accelerator, WiFi debug channels, etc...).
> 
> Co-developed-by: Hemant Kumar <hemantk@...eaurora.org>
> Signed-off-by: Hemant Kumar <hemantk@...eaurora.org>
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
> ---
>  v2: update copyright (2021)
> 
>  drivers/bus/mhi/Kconfig     |  12 +
>  drivers/bus/mhi/Makefile    |   3 +
>  drivers/bus/mhi/wwan_ctrl.c | 559 ++++++++++++++++++++++++++++++++++++++++++++

As Jakub said, why is this file in this directory?

Flat out ignoring review comments is a sure way to always get pushed to
the bottom of the list of things anyone wants to ever look at...

greg k-h