linux-kernel - Re: macb broken on HiFive Unleashed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04a7e801-9a55-c926-34ad-3a7665077a4e@microchip.com>
Date:   Tue, 9 Mar 2021 08:55:10 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <schwab@...ux-m68k.org>, <linux-riscv@...ts.infradead.org>
CC:     <ckeepax@...nsource.cirrus.com>, <andrew@...n.ch>, <w@....eu>,
        <Nicolas.Ferre@...rochip.com>, <daniel@...f.com>,
        <alexandre.belloni@...tlin.com>, <pthombar@...ence.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: macb broken on HiFive Unleashed

Hi Andreas,

On 08.03.2021 21:30, Andreas Schwab wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> One of the changes to the macb driver between 5.10 and 5.11 has broken
> the SiFive HiFive Unleashed.  These are the last messages before the
> system hangs:
> 
> [   12.468674] libphy: Fixed MDIO Bus: probed
> [   12.746518] macb 10090000.ethernet: Registered clk switch 'sifive-gemgxl-mgmt'
> [   12.753119] macb 10090000.ethernet: GEM doesn't support hardware ptp.
> [   12.760178] libphy: MACB_mii_bus: probed
> [   12.881792] MACsec IEEE 802.1AE
> [   12.944426] macb 10090000.ethernet eth0: Cadence GEM rev 0x10070109 at 0x10090000 irq 16 (70:b3:d5:92:f1:07)
> 

I don't have a SiFive HiFive Unleashed to investigate this. Can you check
if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:

git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/
1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag
1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200"
700d566e8171 net: macb: add support for sama7g5 emac interface
ec771de654e4 net: macb: add support for sama7g5 gem interface
f4de93f03ed8 net: macb: unprepare clocks in case of failure
38493da4e6a8 net: macb: add function to disable all macb clocks
daafa1d33cc9 net: macb: add capability to not set the clock rate
edac63861db7 net: macb: add userio bits as platform configuration
9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR'
0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method
e4e143e26ce8 net: macb: add support for high speed interface

Thank you,
Claudiu Beznea

> Andreas.
> 
> --
> Andreas Schwab, schwab@...ux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
>