linux-kernel - Re: [PATCH 3/3] clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Mar 2021 10:02:58 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Dinh Nguyen <dinguyen@...nel.org>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] clk: socfpga: allow compile testing of Stratix 10 /
 Agilex clocks

On 09/03/2021 09:49, Krzysztof Kozlowski wrote:
> On 08/03/2021 19:23, Krzysztof Kozlowski wrote:
>> The Stratix 10 / Agilex / N5X clocks do not use anything other
>> than OF or COMMON_CLK so they should be compile testable on most of
>> the platforms.
>> 
>> Signed-off-by: Krzysztof Kozlowski 
>> <krzysztof.kozlowski@...onical.com> --- drivers/clk/Makefile |  5 
>> +---- drivers/clk/socfpga/Kconfig | 22 ++++++++++++++++------ 2 
>> files changed, 17 insertions(+), 10 deletions(-)
>> 
>> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index 
>> 12e46b12e587..9b582b3fca34 100644 --- a/drivers/clk/Makefile +++ 
>> b/drivers/clk/Makefile @@ -104,10 +104,7 @@ obj-y					+= renesas/ 
>> obj-$(CONFIG_ARCH_ROCKCHIP)		+= rockchip/ 
>> obj-$(CONFIG_COMMON_CLK_SAMSUNG)	+= samsung/ 
>> obj-$(CONFIG_CLK_SIFIVE)		+= sifive/ -obj-$(CONFIG_ARCH_SOCFPGA) +=
>> socfpga/ -obj-$(CONFIG_ARCH_AGILEX)		+= socfpga/ 
>> -obj-$(CONFIG_ARCH_N5X)			+= socfpga/
>> -obj-$(CONFIG_ARCH_STRATIX10) += socfpga/ +obj-y					+= socfpga/
>> obj-$(CONFIG_PLAT_SPEAR)		+= spear/ obj-y					+= sprd/
>> obj-$(CONFIG_ARCH_STI)			+= st/ diff --git
>> a/drivers/clk/socfpga/Kconfig b/drivers/clk/socfpga/Kconfig index
>> 4922cc35f4cc..de7b3137e215 100644 --- a/drivers/clk/socfpga/Kconfig
>> +++ b/drivers/clk/socfpga/Kconfig @@ -1,13 +1,23 @@ #
>> SPDX-License-Identifier: GPL-2.0 +config COMMON_CLK_SOCFPGA +	bool
>> "Intel SoCFPGA family clock support" if COMPILE_TEST
> 
> Kernel test robot found here wrong configuration - possibility to 
> disable the clocks with compile test. I'll send a v2.

Uh, that's not that easy. Intel created three different arm64 architectures
for one real arm64 architecture... I guess it was driven by
the marketing but here we are - the solution would be to have entries like:

bool "Intel SoCFPGA family clock support" if COMPILE_TEST && !ARCH_AGILEX && !ARCH_N5X && !ARCH_SOCFPGA && !ARCH_STRATIX10
...
bool "Intel Stratix / Agilex / N5X clock controller support" if COMPILE_TEST && !ARCH_AGILEX && !ARCH_N5X && !ARCH_STRATIX10
...
bool "Intel Agilex / N5X clock controller support" if COMPILE_TEST && !ARCH_AGILEX && !ARCH_N5X
...

I think it looks wrong. The stratix/agilex/n5x are basically flavors of
socfpga from Linux point of view. This is the same architecture for Linux
kernel, from high level point of view. Instead of going with unified ARCH_SOCFPGA
(like all other platforms, e.g. Renesas, NXP), the Intel create three
different kernel-wide arm64 ARCH_xxx symbols.

It's too much. How about converting all these arm64 Intel platforms to ARCH_SOCFPGA?

Best regards,
Krzysztof