linux-kernel - RE: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8113f0273494e76b7b10c9d81d7997e@AcuMS.aculab.com>
Date:   Tue, 9 Mar 2021 09:12:40 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
        Marco Elver <elver@...gle.com>
CC:     Petr Mladek <pmladek@...e.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Timur Tabi <timur@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: RE: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers
 warning

...
> On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote:
> > On Mon, 8 Mar 2021 at 18:23, Petr Mladek <pmladek@...e.com> wrote:
> 
> > > -       pr_warn("**********************************************************\n");
> > > -       pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > > -       pr_warn("**                                                      **\n");
> > > -       pr_warn("** This system shows unhashed kernel memory addresses   **\n");
> > > -       pr_warn("** via the console, logs, and other interfaces. This    **\n");
> > > -       pr_warn("** might reduce the security of your system.            **\n");
> > > -       pr_warn("**                                                      **\n");
> > > -       pr_warn("** If you see this message and you are not debugging    **\n");
> > > -       pr_warn("** the kernel, report this immediately to your system   **\n");
> >
> > While we're here: This paragraph can be shortened by saying what
> > kernel/trace/trace.c says ("..., report this immediately to your
> > vendor!") which avoids the "administrator! <lots of wasted spaces>".
> 
> Aren't we discussed that and the point was that kernel configuration option is
> in administrator's realm?
> 
> > > -       pr_warn("** administrator!                                       **\n");
> > > -       pr_warn("**                                                      **\n");
> > > -       pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > > -       pr_warn("**********************************************************\n");

If you actually want anyone to notice it you need to splat it out
when root logs in - not just hidden in the middle of the boot messages.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)