linux-kernel - [BUG] Possible bug of missing error return code in __ext4_journalled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7d7b3a16-74c3-1958-85df-fe6d10ed85be@gmail.com>
Date:   Tue, 9 Mar 2021 17:40:03 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: [BUG] Possible bug of missing error return code in
 __ext4_journalled_writepage()

In __ext4_journalled_writepage():
     ......
     inode_bh = ext4_journalled_write_inline_data(inode, len, page);
     if (inode_bh == NULL)
         goto out;
     ......
out:
     unlock_page(page);
out_no_pagelock:
     brelse(inode_bh);
     return ret;

When inode_bh is NULL, ret is not assigned with an error code like -ENOENT.
I wonder whether this is intentional? Or ret should be assigned with 
-ENOENT here?

Best wishes,
Jia-Ju Bai