linux-kernel - Re: [PATCH] net: bridge: fix error return code of do_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210309110121.GD10808@breakpoint.cc>
Date:   Tue, 9 Mar 2021 12:01:21 +0100
From:   Florian Westphal <fw@...len.de>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     pablo@...filter.org, kadlec@...filter.org, fw@...len.de,
        roopa@...dia.com, nikolay@...dia.com, davem@...emloft.net,
        kuba@...nel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, bridge@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bridge: fix error return code of
 do_update_counters()

Jia-Ju Bai <baijiaju1990@...il.com> wrote:
> When find_table_lock() returns NULL to t, no error return code of
> do_update_counters() is assigned.

Its -ENOENT.

>  	t = find_table_lock(net, name, &ret, &ebt_mutex);
                                       ^^^^^

ret is passed to find_table_lock, which passes it to
find_inlist_lock_noload() which will set *ret = -ENOENT
for NULL case.