[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMj1kXGkWj09Jm8VnEJKG3rWXZkJNZR5ROYqs87akKkdM14Hwg@mail.gmail.com>
Date: Tue, 9 Mar 2021 13:39:36 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Michal Suchanek <msuchanek@...e.de>
Cc: Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.
On Tue, 9 Mar 2021 at 13:37, Michal Suchanek <msuchanek@...e.de> wrote:
>
> When using dummy-tools STACKPROTECTOR_PER_TASK is unconditionally
> selected. This defeats the purpose of the all-enabled tool.
>
What is dummy-tools and why should we care about it?
> Description copied from arm
>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
> arch/arm64/Kconfig | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index a8ff7cd5f096..f59d391e31a4 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1549,9 +1549,20 @@ config RANDOMIZE_MODULE_REGION_FULL
> config CC_HAVE_STACKPROTECTOR_SYSREG
> def_bool $(cc-option,-mstack-protector-guard=sysreg -mstack-protector-guard-reg=sp_el0 -mstack-protector-guard-offset=0)
>
> +
> config STACKPROTECTOR_PER_TASK
> - def_bool y
> + bool "Use a unique stack canary value for each task"
> depends on STACKPROTECTOR && CC_HAVE_STACKPROTECTOR_SYSREG
> + default y
> + help
> + Due to the fact that GCC uses an ordinary symbol reference from
> + which to load the value of the stack canary, this value can only
> + change at reboot time on SMP systems, and all tasks running in the
> + kernel's address space are forced to use the same canary value for
> + the entire duration that the system is up.
> +
> + Enable this option to switch to a different method that uses a
> + different canary value for each task.
>
> endmenu
>
> --
> 2.26.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Powered by blists - more mailing lists