linux-kernel - Re: [PATCH v3 05/15] dt_bindings: mfd: Add ROHM BD71815 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06c8e7339ebc3e1802aa1e9c213de9392671a8a5.camel@fi.rohmeurope.com>
Date:   Tue, 09 Mar 2021 14:51:07 +0200
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        devicetree@...r.kernel.org, linux-power@...rohmeurope.com,
        Rob Herring <robh+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v3 05/15] dt_bindings: mfd: Add ROHM BD71815 PMIC

Hello Rob,

On Mon, 2021-03-08 at 10:39 -0700, Rob Herring wrote:
> On Mon, 08 Mar 2021 12:40:50 +0200, Matti Vaittinen wrote:
> > Document DT bindings for ROHM BD71815.
> > 
> > BD71815 is a single-chip power management IC mainly for battery-
> > powered
> > portable devices. The IC integrates 5 bucks, 7 LDOs, a boost driver
> > for
> > LED, a battery charger with a Coulomb counter, a real-time clock, a
> > 32kHz
> > clock and two general-purpose outputs although only one is
> > documented by
> > the data-sheet.
> > 
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > ---
> >  .../bindings/mfd/rohm,bd71815-pmic.yaml       | 201
> > ++++++++++++++++++
> >  1 file changed, 201 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:

I am sorry to bother but I've spent a while trying to reproduce this.
For some reason I can't trigger the error from

'make dt_binding_check' or
'make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/rohm,bd71815-
pmic.yaml'

even after I ran

'pip3 install dtschema --upgrade --user'.

I should also have yamllint installed.

> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Unknown file referenced: [Errno 2] No such file or directory:
> '/usr/local/lib/python3.8/dist-
> packages/dtschema/schemas/regulator/rohm,bd71815-regulator.yaml'

This bothers me slightly. The patch 04/15 should bring-in the
rohm,bd71815-regulator.yaml. Does this error indicate that file is
missing or is my $ref somehow invalid?

*** opinion follows - not sure if it just me but... ***

I know I should probably keep my mouth shut but... I am more and more
thinking that the yaml bindings are yet another 'excessive unit-test'
type solution. Tooling which should "force doing things correctly" is
eventually hindering development and causing the end result being sub-
optimal.

I mean that creating binding docs takes way too much time from someone
like me who is "yaml-illiterate". And when I eventually get yaml done -
the end result is far less descriptive for human eyes than the "good
old" free-text format would've been. I know one can add comments - but
I don't see much of them in the binding docs...

Best Regards
 -- Matti Vaittinen