linux-kernel - [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com>
Date:   Tue,  9 Mar 2021 20:58:38 +0800
From:   Dong Aisheng <aisheng.dong@....com>
To:     linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     dongas86@...il.com, kernel@...gutronix.de, shawnguo@...nel.org,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
        cw00.choi@...sung.com, abel.vesa@....com,
        Dong Aisheng <aisheng.dong@....com>
Subject: [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats

Check .get_dev_status() in devfreq_update_stats in case it's abused
when a device does not provide it.

Signed-off-by: Dong Aisheng <aisheng.dong@....com>
---
 drivers/devfreq/governor.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index 31af6d072a10..67a6dbdd5d23 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -89,6 +89,9 @@ int devfreq_update_target(struct devfreq *devfreq, unsigned long freq);
 
 static inline int devfreq_update_stats(struct devfreq *df)
 {
+	if (!df->profile->get_dev_status)
+		return -EINVAL;
+
 	return df->profile->get_dev_status(df->dev.parent, &df->last_status);
 }
 #endif /* _GOVERNOR_H */
-- 
2.25.1