linux-kernel - Re: [PATCH 03/11] PM / devfreq: fix the wrong set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Mar 2021 23:16:02 +0800
From:   Dong Aisheng <dongas86@...il.com>
To:     Chanwoo Choi <cwchoi00@...il.com>
Cc:     Dong Aisheng <aisheng.dong@....com>,
        Linux PM <linux-pm@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        open list <linux-kernel@...r.kernel.org>,
        myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Abel Vesa <abel.vesa@....com>
Subject: Re: [PATCH 03/11] PM / devfreq: fix the wrong set_freq path for
 userspace governor

On Tue, Mar 9, 2021 at 11:13 PM Chanwoo Choi <cwchoi00@...il.com> wrote:
>
> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
> > Fix the wrong set_freq path for userspace governor.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> > ---
> >   drivers/devfreq/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> > index 00704efe6398..20373a893b44 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -62,7 +62,7 @@ config DEVFREQ_GOV_USERSPACE
> >       help
> >         Sets the frequency at the user specified one.
> >         This governor returns the user configured frequency if there
> > -       has been an input to /sys/devices/.../power/devfreq_set_freq.
> > +       has been an input to /sys/devices/.../userspace/set_freq.
> >         Otherwise, the governor does not change the frequency
> >         given at the initialization.
> >
> >
>
> Looks good. But this patch just fix the information in Kconfig
> instead of fixing the wrong operation. To clarify the commit message,
> I'll change the patch title and commit message as following:

Looks like more accurate. Thanks.

Regards
Aisheng

>
>      PM / devfreq: Fix the wrong set_freq path for userspace governor in
> Kconfig
>
>      Fix the wrong set_freq path for userspace governor in Kconfig.
>
>      Signed-off-by: Dong Aisheng <aisheng.dong@....com>
>
>
> Applied it. But, if you have any other objection, please let me know.
>
>
> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi