linux-kernel - Re: [PATCH 1/2] mips: syscalls: switch to generic syscalltbl.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210310150705.GA12960@alpha.franken.de>
Date:   Wed, 10 Mar 2021 16:07:05 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Alexander Lobakin <alobakin@...me>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [PATCH 1/2] mips: syscalls: switch to generic syscalltbl.sh

On Mon, Mar 01, 2021 at 11:48:24PM +0900, Masahiro Yamada wrote:
> Many architectures duplicate similar shell scripts.
> 
> This commit converts mips to use scripts/syscalltbl.sh. This also
> unifies syscall_table_32_o32.h and syscall_table_64_o32.h into
> syscall_table_o32.h.
> 
> The offset parameters are unneeded here; __SYSCALL(nr, entry) is defined
> as 'PTR entry', so the parameter 'nr' is not used in the first place.
> 
> With this commit, syscall tables and generated files are straight
> mapped,  which makes things easier to understand.
> 
>   syscall_n32.tbl  -->  syscall_table_n32.h
>   syscall_n64.tbl  -->  syscall_table_n64.h
>   syscall_o32.tbl  -->  syscall_table_o32.h
> 
> Then, the abi parameters are also unneeded.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  arch/mips/include/asm/Kbuild            |  7 +++--
>  arch/mips/kernel/scall32-o32.S          |  4 +--
>  arch/mips/kernel/scall64-n32.S          |  3 +--
>  arch/mips/kernel/scall64-n64.S          |  3 +--
>  arch/mips/kernel/scall64-o32.S          |  4 +--
>  arch/mips/kernel/syscalls/Makefile      | 31 ++++++---------------
>  arch/mips/kernel/syscalls/syscalltbl.sh | 36 -------------------------
>  7 files changed, 17 insertions(+), 71 deletions(-)
>  delete mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]