linux-kernel - RE: [PATCH v3 1/3] scsi: ufshcd: use a function to calculate versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB65757AE022DFB7C1DA9B6D87FC919@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Wed, 10 Mar 2021 16:34:32 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Caleb Connolly <caleb@...nolly.tech>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "ejb@...ux.ibm.com" <ejb@...ux.ibm.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "jaegeuk@...nel.org" <jaegeuk@...nel.org>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>
Subject: RE: [PATCH v3 1/3] scsi: ufshcd: use a function to calculate versions

> @@ -9298,10 +9291,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
> *mmio_base, unsigned int irq)
>         /* Get UFS version supported by the controller */
>         hba->ufs_version = ufshcd_get_ufs_version(hba);
> 
> -       if ((hba->ufs_version != UFSHCI_VERSION_10) &&
> -           (hba->ufs_version != UFSHCI_VERSION_11) &&
> -           (hba->ufs_version != UFSHCI_VERSION_20) &&
> -           (hba->ufs_version != UFSHCI_VERSION_21))
> +       if (hba->ufs_version < ufshci_version(1, 0))
>                 dev_err(hba->dev, "invalid UFS version 0x%x\n",
>                         hba->ufs_version);
Here you replaces the specific allowable values, with an expression
That doesn't really reflects those values.