linux-kernel - Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJzFJvwTEk3u+g3Fjv_K2Te9F3hyZnEPWurWjxgs2dShg@mail.gmail.com>
Date:   Wed, 10 Mar 2021 10:21:56 -0700
From:   Rob Herring <robh@...nel.org>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jonas Gorski <jonas.gorski@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: document
 BCM6345 external interrupt controller

On Sun, Mar 7, 2021 at 3:12 AM Álvaro Fernández Rojas <noltari@...il.com> wrote:
>
> Hi Rob,
>
> El 06/03/2021 a las 21:14, Rob Herring escribió:
> > On Wed, Feb 24, 2021 at 08:56:39AM +0100, Álvaro Fernández Rojas wrote:
> >> Document the binding for the BCM6345 external interrupt controller.
> >>
> >> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> >> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>
> >> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> >> ---
> >>   v3: pass dt_binding_check.
> >>   v2: fix title typo.
> >>
> >>   .../brcm,bcm6345-ext-intc.yaml                | 78 +++++++++++++++++++
> >>   1 file changed, 78 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> >> new file mode 100644
> >> index 000000000000..a691510e78b7
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> >> @@ -0,0 +1,78 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Broadcom BCM6345 external interrupt controller
> >> +
> >> +maintainers:
> >> +  - Álvaro Fernández Rojas <noltari@...il.com>
> >> +  - Jonas Gorski <jonas.gorski@...il.com>
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - brcm,bcm6318-ext-intc
> >> +      - brcm,bcm6345-ext-intc
> >> +
> >> +  "#interrupt-cells":
> >> +    const: 2
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  "#address-cells":
> >> +    const: 0
> >> +
> >> +  interrupt-controller: true
> >> +
> >> +  interrupts:
> >> +    description: Specifies the interrupt line(s) in the interrupt-parent
> >> +      controller node. Valid values depend on the type of parent interrupt
> >> +      controller.
> >> +    maxItems: 4
> >> +
> >> +  brcm,field-width:
> >> +    description: Interrupt controller field width (the default is 4).
> >
> > default: 4
> >
> >> +    maxItems: 1
> >
> > All uint32's are 1 item.
>
> Ok, so I should remove this :)
>
> >
> > What's the set or range of values?
>
> Only BCM6348 needs to set this value to 5, other BCM63xx use the default
> value of 4 (BCM3368, BCM6318, BCM6328, BCM6338, BCM6345, BCM6358,
> BCM6362, BCM6368, BCM63268).

So:

enum: [ 4, 5 ]