linux-kernel - Re: [PATCH 0/3] PSP TEE driver update and bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f8d3fe9-a945-811e-c1ec-b82f45c1d272@amd.com>
Date:   Wed, 10 Mar 2021 09:57:48 +0530
From:   Rijo Thomas <Rijo-john.Thomas@....com>
To:     Tom Lendacky <thomas.lendacky@....com>,
        John Allen <john.allen@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Cc:     Mythri Pandeshwara krishna <mythri.pandeshwarakrishna@....com>,
        Devaraj Rangasamy <Devaraj.Rangasamy@....com>,
        Jens Wiklander <jens.wiklander@...aro.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH 0/3] PSP TEE driver update and bug fixes



On 09/03/21 10:06 pm, Tom Lendacky wrote:
> On 3/9/21 2:11 AM, Rijo Thomas wrote:
>> The first patch helps to improve the response time by reducing the
>> polling time of the tee command status variable.
>>
>> Second patch is a bug fix to handle multi-threaded use-case.
>> During testing, race condition was seen due to missing synchronisation
>> in writes to the TEE ring buffer. This patch helps to resolve that.
>>
>> Third patch is to update the copyright year for the tee driver files.
>>
> 
> Just something to think about and not as part of this patch series, but
> think about submitting a patch that adds you as maintainer of the TEE
> portion of the driver (see how the SEV portion is handled).
> 

Sure Tom. I will add myself as maintainer for TEE portion of driver.
I will post that as a separate patch.

Thanks,
Rijo

> Thanks,
> Tom
> 
>> Rijo Thomas (3):
>>   crypto: ccp - reduce tee command status polling interval from 5ms to
>>     1ms
>>   crypto: ccp - fix command queuing to TEE ring buffer
>>   crypto: ccp - update copyright year for tee
>>
>>  drivers/crypto/ccp/tee-dev.c | 57 ++++++++++++++++++++++++------------
>>  drivers/crypto/ccp/tee-dev.h | 20 +++++++++++--
>>  2 files changed, 57 insertions(+), 20 deletions(-)
>>